frontend: Improve preview source snapping#12298
Open
Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Open
frontend: Improve preview source snapping#12298Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Conversation
PatTheMav
reviewed
Sep 25, 2025
Member
PatTheMav
left a comment
There was a problem hiding this comment.
Functionally this PR is fine, but it seems very brute force and not particularly efficient to me and falls victim to "featuritis", just piling on little features one by one, each doing its own thing in isolation with no regard to other (similar) features and the architecture behind it.
Preview control drawing should be a single process, by a single responsible entity in code that knows about all of its "features" and thus set up a single render pass to draw all the pieces it knows should be visible for any given frame.
acac8ce to
50873c1
Compare
a7a004e to
f53cd97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a number of changes to source snapping in the preview:
Additionally
obs64_wuvM7eemGG.mp4
Motivation and Context
I want to improve source snapping behaviour and visual feedback
How Has This Been Tested?
Moved a bunch of sources around. Toggles relevant snapping settings on and off to ensure behaviour matched settings.
Types of changes
Checklist: