frontend,libobs: Add Program Files plugin path and module dedup check#13203
Closed
marcusbooker77 wants to merge 1 commit intoobsproject:masterfrom
Closed
frontend,libobs: Add Program Files plugin path and module dedup check#13203marcusbooker77 wants to merge 1 commit intoobsproject:masterfrom
marcusbooker77 wants to merge 1 commit intoobsproject:masterfrom
Conversation
Add standard OBS Studio installation directory to plugin search paths so third-party plugins from Program Files are available in development builds. Add dedup check in load_all_callback() to prevent double-loading modules found in multiple search paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
We do not accept AI-generated PRs. In the future, please take the time to read any project's published guidelines before submitting PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small improvements to the Windows plugin loading system:
1. Add Program Files plugin search path (
OBSBasic.cpp)Adds
C:\Program Files\obs-studio\obs-plugins\64bit\as an additional module search path inAddExtraModulePaths(). This allows development/custom builds of OBS to discover and load third-party plugins that were installed by the standard OBS installer into Program Files.Use case: When building OBS from source for development or testing, third-party plugins (StreamFX, Move Transition, etc.) installed via the official installer are invisible to the dev build. This change makes them available without manual copying.
2. Module deduplication check (
obs-module.c)Adds a check in
load_all_callback()to skip modules that have already been loaded from a higher-priority search path. Without this, the same plugin DLL found in multiple search paths would be loaded twice, causing duplicate sources/filters in the UI and potential memory/stability issues.Test Plan
C:\Program Files\obs-studio\obs-plugins\64bit\LOG_DEBUGmessages confirm dedup is working:"Skipping module 'xxx', already loaded"AddExtraModulePathsbefore the new path)#if defined(_WIN32)guarded)Files Changed
frontend/widgets/OBSBasic.cppAddExtraModulePaths()libobs/obs-module.cload_all_callback()🤖 Generated with Claude Code