Add pause-resume feature to ffmpeg plugin to auto pause when switching away#7541
Closed
dcmouser wants to merge 1 commit intoobsproject:masterfrom
Closed
Add pause-resume feature to ffmpeg plugin to auto pause when switching away#7541dcmouser wants to merge 1 commit intoobsproject:masterfrom
dcmouser wants to merge 1 commit intoobsproject:masterfrom
Conversation
…g away Add pause-resume feature to ffmpeg plugin to auto pause when switching away
gxalpha
requested changes
Oct 6, 2022
Member
gxalpha
left a comment
There was a problem hiding this comment.
See the unresolved comment on #6112 (review).
The part about commit messages applies to all your recently opened Pull Requests.
Author
|
I'm happy to withdraw this pull request in favor of this one: #6739 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option for ffmpeg (video) sources to say they want to be paused on deactivate and resumed on activate, instead of default to stop and restart.
Description
This patch adds a checkbox option to video sources (after "close file when inactive"), labeled "pause and resume"; when enabled the video source will be PAUSED when the source is deactivated, and then RESUMED when it is later reactivated. This is in contrast to the other options which allow EITHER that video sources are stopped/unloaded and restarted, or are left playing in the background.
Motivation and Context
This is based on this request:
https://obsproject.com/forum/threads/request-for-video-media-source-pause-and-unpause-when-showing-hiding.154270/#post-565354
The two motivations are: 1) to allow video sources to be paused when switched away from and then resumed and 2) to reduce cpu use when not showing a scene with a video that you will return to.
How Has This Been Tested?
Tested on windows OBS version 28; it's a super simple modification which makes no assumptions about the video sources.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
NOTE: This is my first contribution to OBS -- please feel free to modify it as you see fit.