Events: Add from and to scene names to transition events

[duncte123]

Description

As stated in #983 the v5 transition events are lacking a severe amount of data rendering them pretty much useless without having your own state (that desyncs the moment you have two clients)

Motivation and Context

The missing from and to scenes on the transition events is what's keeping me on v4. When this PR is released I will be able to switch off v4 and use v5.
It would fix #983 but currently the duration is wonky due to an internal OBS bug so not completely

How Has This Been Tested?

Tested OS(s):

• Ubuntu 22.04
• Windows 10 22H2 19045.4412

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have read the Contributing Guidelines.
• All commit messages are properly formatted and commits squashed where appropriate.
• My code is not on master or a release/* branch.
• The code has been tested.
• I have included updates to all appropriate documentation.

[duncte123]

Whoops, soft resetted too much

[inkfarer]

I'd be thrilled to have this merged, knowing what scene is being transitioned to as the scene transition starts is very useful for me.

@duncte123 - Should the transition events also contain the UUIDs of the scenes being transitioned from and to?

[duncte123]

Should the transition events also contain the UUIDs of the scenes being transitioned from and to?

Personally I don't have any use case for this, if any of the maintainers want this functionality I'd be happy to add it next to the scene names

[duncte123]

@RytoEX @tt2468 (or any other maintainers) Could this PR get a review?

[Tina-otoge]

Could anyone look into this? I have just setup automations when changing OBS scenes and I realize the current CurrentProgramSceneChanged only fires AFTER the transition is complete, but in my use case the timing is critical and I need to react to the event BEFORE the transition ends. So I started looking into the SceneTransitionStarted event, only to realize it does not have information about the scene we are transitioning into...

My solution for now has been to migrate my code from WebSocket protocol 5 to WebSocket protocol 4 and use the TransitionBegin event instead, which is really not ideal.

[TheOnlyJoey]

Can this be revisited?
Websocket 4 is becoming frustrating to maintain for newer versions, and Websocket 5 is incomplete without this patch for a lot of workflows.

[duncte123]

Added UUIDs for scenes and renamed the fields of fromScene and toScene

[duncte123]

@RytoEX saw that you're active on the repo again, could you have a look at this PR? It's been 2 years without any comment from a maintainer.

[RytoEX]

@RytoEX saw that you're active on the repo again, could you have a look at this PR? It's been 2 years without any comment from a maintainer.

I am not familiar enough with websockets or this PR to provide a review. I would require a review from another maintainer who understands the problem this is trying to solve.

[TheOnlyJoey]

@RytoEX saw that you're active on the repo again, could you have a look at this PR? It's been 2 years without any comment from a maintainer.

I am not familiar enough with websockets or this PR to provide a review. I would require a review from another maintainer who understands the problem this is trying to solve.

The problem that this PR fixes is a deprecation between the v4 and v5 websocket implementation.
Currently there is no way to set a "From" and "To" scene that is required in a lot of workflows.
This PR re-adds this functionality in a clean and compatible way.

[TheOnlyJoey]

An additional note that this patch has been serving me well for over a year now.