Merged
Conversation
added 2 commits
June 28, 2023 15:36
xavierleroy
approved these changes
Jul 18, 2023
Contributor
xavierleroy
left a comment
There was a problem hiding this comment.
Looks reasonable to me. #132 proposes to skip this linking test if pkg_config is available, but I don't know if it's the case for the Windows ports of OCaml, so it's obviously better if the original linking test works on Windows too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exported from #133, this patch was suggested by @dra27 for fixing the build with OCaml 5 on windows.
I don't really understand the limitation regarding flexlink and what hack were presents in opam-repository-mingw packages.
I'm counting on @dra27 to answer any question regarding this PR.