chore: remove unnecessary rm -rf vendor/... step#13664
Open
Alizter wants to merge 1 commit intoocaml:mainfrom
Open
chore: remove unnecessary rm -rf vendor/... step#13664Alizter wants to merge 1 commit intoocaml:mainfrom
Alizter wants to merge 1 commit intoocaml:mainfrom
Conversation
The bootstrapping process knows how to build the vendored code here and the normal build does not know about it due to the lack of dune file. Therefore this is no longer a necessary step. Signed-off-by: Ali Caglayan <alizter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootstrapping process knows how to build the vendored code here and the normal build does not know about it due to the lack of dune file. Therefore this is no longer a necessary step.