Try to resolve references in stage 0#1261
Draft
panglesd wants to merge 8 commits intoocaml:masterfrom
Draft
Conversation
When docstrings go are inherited, eg from an include or a functor expansion, warnings may be generated in one docs while the fix is in a dependency. This commit allows to tag each docstring with a boolean to indicate whether it comes from a unit with warnings enabled or disabled.
This means that for any documentation file in a package, either mld or module interface, any module in the entire package can be referenced with or without a fully qualified path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some references get "moved" to some other context when expansions are computed, which make them resolve to something else/not resolve anymore.
This PR tries to resolve reference at the earliest, before any expansions are computed: at load time. So resolved references go to the original referenced item.
This is extracted from some branch of @jonludlam, as a draft. I have not reviewed the commits. It put it as a draft, just so that the idea does not get forgotten, but it is planned as post 3.0
(currently based on #1260)