Open
Conversation
When compiling with -no-alias-deps, module aliases produce imports without digests. This test demonstrates that odoc currently resolves these imports by looking them up in the include path, which can find stale artifacts from a previous build and associate the wrong digest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When compiling with -no-alias-deps, module aliases produce imports without digests. Previously, resolve_imports would eagerly look up these modules in the include path, potentially finding stale .odoc artifacts from a previous build. This would associate the wrong digest with the import, breaking incremental rebuilds. Skip resolution for Unresolved (_, None) imports, leaving them unresolved in the output .odoc file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The unresolved reference warning during link is always non-fatal, so --warn-error has no effect on it. This test demonstrates the bug: the warning is not promoted to an error and the exit code is 0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, resolution failures in Errors.report used Lookup_failures.report_internal which hardcoded non_fatal:true, meaning they would never cause a build failure even when --warn-error was passed. Switch to Lookup_failures.report_warning so that all resolution failures (modules, types, references, etc.) respect --warn-error. Root errors (missing dependencies) retain their own separate handling via report_root. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two simple bugfixes. Important for the upcoming dune rules.