Add a MacOS build: A couple of different options#78
Open
pettyalex wants to merge 2 commits intoodelaneau:masterfrom
Open
Add a MacOS build: A couple of different options#78pettyalex wants to merge 2 commits intoodelaneau:masterfrom
pettyalex wants to merge 2 commits intoodelaneau:masterfrom
Conversation
…ke variables, or make the makefile conditional. Also, for building on Mac, some references to std::setiosflags had to be updated to include the std:: namespace
|
Just FYI, there is also an open homebrew-core PR on this, Homebrew/homebrew-core#116162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demonstrates a couple of approaches that could be used to make this shapeit4 build and run on MacOS. We can use either a script that overrides make variables, or make the makefile conditional. Also, for building on Mac, some references to std::setiosflags had to be updated to include the std:: namespace.
I've seen several requests to have this operate on Mac OS. Also, the -mavx2 and -mfma flags can be left on, as they're supported on Intel macs, and ignored with a warning on Apple Silicon Macs.
Existing users wanting to use this on a Mac:
#15
#36