Enhancement: Docker Swarm stack name added.#26
Enhancement: Docker Swarm stack name added.#26adityaofficial10 wants to merge 1 commit intoodk-x:developmentfrom
Conversation
|
@linl33 |
|
@linl33 |
linl33
left a comment
linl33
left a comment
There was a problem hiding this comment.
2 small issues but otherwise the script works.
I noticed that your commit was based off of the master branch. There are changes in the development branch that are useful for testing.
| print("Attempting to save updated https configuration") | ||
| write_to_env_file(env_file_location, domain, email) | ||
|
|
||
| write_to_env_file(env_file_location, domain, email, stack_name) |
There was a problem hiding this comment.
This should not be guarded behind enforce_https anymore.
|
|
||
| try: | ||
| domain, email = parse_env_file(env_file_location) | ||
| domain, email, stack_name = parse_env_file(env_file_location) |
There was a problem hiding this comment.
For a user coming from a previous version, stack_name would be None here. Please add a check.
|
This looks fine to me 👍 |
|
(oops - sorry I fumbled - didn't mean to close it.) |
|
@adityaofficial10 please take a look at the PR feedback and possibly make the requested changes to address the issues. You can push additional commits to the same branch and it will automatically add it to the PR. |
|
@wbrunette |
|
@adityaofficial10 no worries. We are trying to provide more directions for GSoC/Outreachy since it may be someone's first time involved in open-source projects. |
|
@wbrunette |
|
@adityaofficial10 Could you give us an update on this pull request? Let us know if you're having any difficulties or questions. |
|
@linl33 |
|
@wbrunette I'm still waiting on changes requested in the previous review. |
|
@adityaofficial10 can you give us an update on your progress? Do you have any questions? |
|
@adityaofficial10 can you give us an update on your progress? Do you have any questions? |
|
@wbrunette @linl33 |
|
Hello team, I'm an Outreachy applicant for the winter 2023 season and have been assigned issue: issue: https://github.com/odk-x/tool-suite-X/issues/194 Regards, |
|
@MariaAngella you should start fresh with your own branch and learn about Git. |
|
@wbrunette will work from my branch thanks. Regards, |
|
@wbrunette , kindly advise if I'm on the right track my branch Thank you and regards, |
6 participants
Fixes issue: odk-x/tool-suite-X#194
What changes have been made?