Open
Conversation
Member
r0ssing
commented
Mar 2, 2024
r0ssing
commented
- Bumped postgres and nginx versions.
- Removed the specific branch when cloning sync-endpoint (= this can be controlled by setting default branch on sync-endpoint repo)
- Updated README.md
Update README.md
Updated example to Ubuntu 22.04, fixed broken link
wbrunette
requested changes
Mar 3, 2024
Remember to change this (ie. remove -b <branch spec>) when merging to develop/main
Member
Author
|
Hi @wbrunette - I've updated the checkout command to checkout the taketwo branch. This PR still targets the development branch of sync-endpoint-default-setup though - should we create an "updatejdk"-branch in this repo as well and redirect this PR to that? |
Member
|
a personal opinion, I think it's fine, evetntually all update-jdk branches will be moved to development as we will likely just have "development" and "main" but happy to have consistency though in the short term with the upgrade-jdk |
Fixed some errors due to updated versions (timeout no longer accepts "-t", postgresql no longer accepts storing unencrypted passwords)
Member
Author
|
Upon further testing I noticed some edits had to be made to db-bootstrap (encrypting stored password, updated 'timeout' command). @wbrunette: can we merge this to develop branch now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.