[IMP] empty #4925
Open
[IMP] empty #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
Faruk372742
force-pushed
the
master-hr-onboarding-faavc
branch
from
f5a9ca2 to
d57f536
Compare
Unit test for: test_virtual_remaining_leaves function (tests are upgraded and reduced) Reproducing bug: When you come to all time of section and press to the time off type, the error pop-up occurs. Bug cause: In the function _search_virtual_remaining_leaves, the operator function takes only one value and '>' (gt) operator gives an error since it takes two arguments Solution: The value also put as an second argument to the op function and by that way the virtual_remaining_leaves can be compared with the value in the function. task - 5447489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.