[LINT] sale_gelato: lint + format #4954
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: - An error was shown when opening the Employee list view. - A custom list view behavior was removed earlier, but its reference was still present in the Employee list view, causing the Employee list to fail to load. Fix: - Removed the outdated reference from the Employee list view and restored the default list behavior so the view loads correctly. task-5484692 closes odoo#243269 Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
Before this commit, some elements were not aligned and the image was too big, now it looks more balanced. task-5223875 closes odoo#234693 Signed-off-by: Claire Nguyen (clan) <clan@odoo.com>
Steps to reproduce: ==================== - Go to the website in chrome - Create a Image Wall (gallery) - Add a lot of images. See attachments for a .zip file in task to test it. - Try to change the display mode or number of column -> An error will appear when the cursor get on the dropdown options. Cause: ====== In Google Chrome, calling img.decode() on a large set of images simultaneously (e.g., in an image wall) can result in `EncodingError: The source image cannot be decoded for some images`. This is a known Chromium issue (See [1]) where the browser's image decoder gets overwhelmed or hits a concurrency limit, causing it to reject valid images. The current implementation uses Promise.all(imgLoaded), which utilizes a "fail-fast" mechanism. Consequently, if a single image fails to decode due to this browser limitation, the entire promise rejects immediately. This unhandled rejection interrupts the execution flow, preventing the display mode or column options from functioning correctly when the user interacts with them. Solution: ======== Replace Promise.all(imgLoaded) with Promise.allSettled(imgLoaded). Unlike Promise.all, Promise.allSettled waits for all promises to finish regardless of whether they succeeded or failed. [1]: https://issues.chromium.org/issues/40261318 opw-5249130 closes odoo#243133 X-original-commit: 4758cf8 Signed-off-by: Francois Georis (fge) <fge@odoo.com> Signed-off-by: Saif Allah Ben Khalil (sben) <sben@odoo.com>
Before this commit, changing the animation speed would reset the colors applied to the image shape. This was due to the code always considering the shape as new because the current shape id wasn't retrieved. Therefore, the colors would be reset to the default ones. Steps to reproduce the issue: - Drop a snippet with an image - Click on the image - Add an image shape. It should be animated. - Change the image shape color - Change the image shape animation speed => The image shape color was reset. task-5375497 X-original-commit: 8fc84e4 Part-of: odoo#243091 Signed-off-by: Romaric Moyeuvre (romo) <romo@odoo.com> Signed-off-by: Francois Georis (fge) <fge@odoo.com>
X-original-commit: f440027 Part-of: odoo#243091 Signed-off-by: Romaric Moyeuvre (romo) <romo@odoo.com> Signed-off-by: Francois Georis (fge) <fge@odoo.com>
closes odoo#243091 X-original-commit: 3f81e56 Signed-off-by: Romaric Moyeuvre (romo) <romo@odoo.com> Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Steps to reproduce: Open Discuss > Configuration > Settings. Before this commit: Non-admin users encounter an access error when clicking 'Settings'. After this commit: The 'Settings' menu item is now hidden for users who are not part of the 'Role / Administrator' group. closes odoo#243352 X-original-commit: 2fa6759 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
The `simulateArrowKeyPress` method used in hoot tests performs both an actual `press` and modifies the selection. However, in some cases, the `press` already updates the selection because of our own listeners, which leads to a selection similar to performing the action twice. This commit avoids this by making sure the default `press` did not get prevented by our own custom listeners before modifying the selection. task-5438683 closes odoo#243327 X-original-commit: df01277 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Steps to reproduce ------------------ 1. In PoS settings, set the "Tax Display" to "Tax-Excluded Price" 2. Enable customer display 3. Open a PoS session, and open the customer display simultaneously 4. Add products, notice that the total in PoS is price included as expected. However, the total in cusromer display is tax excluded, so customer thinks he will be pay less. Why it happens -------------- In the refactors done in 9538698, we mistakenly set the order.amount (i.e. total amount) to follow the config "Tax Display". However, that price should always be tax incl. In this PR, we now use the `currencyDisplayPriceIncl` getter, instead of the config dependent `currencyDisplayPrice`. Additional enhancements ----------------------- In case of "Tax-Excluded" price config, we now display the order subtotal (total price excluded) and the taxes amount as well, for more detailed breakdown of the prices. It follows the cart view in the main PoS products display. opw-5401560 closes odoo#243369 X-original-commit: 41e7026 Signed-off-by: David Monnom (moda) <moda@odoo.com> Signed-off-by: Hadi El Yakhni (hael) <hael@odoo.com>
This reverts commit 9eb8ac4.
Purpose: - Drag and drop handlers don’t function on mobile devices. Therefore, they have been removed for mobile devices. task-5155786 Part-of: odoo#235426 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Purpose: - On mobile devices, tab buttons used for color tabs and gradient types can exceed the available viewport width, causing layout overflow. - Replace these tab buttons with a dropdown on mobile to prevent overflow and improve usability. task-5155786 closes odoo#235426 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
closes odoo#242003 Signed-off-by: Didier Debondt (did) <did@odoo.com>
In some search views the list of filters can be huge which impairs the
readability.
This commit adds support for inner filters in `<search/>` allowing them
to be collapsed into a parent filter, reducing the number of visible
entries in the search view.
The logic for date filters was partially merged with the one for inner
filters since the syntax is the same.
It can be used inside a search arch as such:
```xml
<search>
<filter string="Priority">
<filter string="Urgent" domain="[('priority', '=', 3)]"
name="urgent_priority"/>
<filter string="High" domain="[('priority', '=', 2)]"
name="high_priority"/>
<filter string="Medium " domain="[('priority', '=', 1)]"
name="medium_priority"/>
<filter string="Low" domain="[('priority', '=', 0)]"
name="low_priority"/>
</filter>
</search>
```
task-5232012
closes odoo#241459
Related: odoo/enterprise#102947
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
- renamed 'discussions' to 'messages' to align with the 'send message' button. - updated 'note' to 'notes' for consistency with other plural labels. - reordered 'notes' and 'activities' to match the button order in the chatter. upgrade: odoo/upgrade#7759 task-3081163 closes odoo#204940 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
When dropping or moving any snippet, we scroll to this snippet. There was an offset of 50px above it to show the previous snippet, to avoid having the dropzone above it over the header or outside the screen. To show that a snippet takes 100% of the screen height, it was decided to remove this offset on drop only. task-5387623 closes odoo#238684 Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Move import in the file where it's actually used. closes odoo#243510 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This commit expands the useBackButton hook to manage mobile "back" gesture and "back" navigation button. This allows modal-like components to be closed via "back" gesture, replacing the unwanted behavior of navigating back. fixes task-5041807 fixes task-4563827 closes odoo#229643 Related: odoo/enterprise#102809 Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
…gory * = im_livechat Before this commit, the discuss sidebar only showed the visitor’s name, making it difficult to know the context of a conversation without opening it. This commit displays the livechat conversation description in the sidebar so agents can quickly understand the context of a conversation. Task-5404924 X-original-commit: 7cdaa94 Part-of: odoo#243351 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Rename discuss_sidebar_channel_actions_patch to discuss_sidebar_channel_patch, as the previous name was misleading. task-5404924 closes odoo#243351 X-original-commit: 732ec0a Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
1. Improve the creation form of discuss categories. 2. Add channel in search view for discuss categories. 3. Update discuss category settings view and the text description. task-5486664 closes odoo#243423 X-original-commit: 741c367 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com> Signed-off-by: Zelong Lin (zel) <zel@odoo.com>
…bo popup Before this commit: ================= Product cards with long names caused a slight vertical misalignment in the combo configurator popup, resulting in inconsistent card sizes within the grid. After this commit: ================== Ensure all product cards remain uniformly aligned and maintain consistent dimensions in the combo configurator popup, even when product names are long. Task:5447320 closes odoo#243322 X-original-commit: 2d38730 Signed-off-by: David Monnom (moda) <moda@odoo.com> Signed-off-by: Jitendra Kumar Prajapat (jipr) <jipr@odoo.com>
When verifying whether nodes are similar, their padding and margin are tested. Only the nodes with no padding nor margin are considered as similar. Because of this, nodes such a `code.o_inline_code` are considered as not similar to each other, and do not get merged together when they are adjacent. This commit solves this by also verifying whether the padding and the margin of both nodes are identical when nodes are `code.o_inline_code`. Steps to reproduce: - Insert a `<code>` inline block with some text inside - Put the cursor in the middle - Press Enter to split it onto two paragraphs - Press Backspace to put them back together => The line contained two adjacent code blocks task-5375140 X-original-commit: 98f0e8f Part-of: odoo#243424 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
When removing the last character inside a `code.o_inline_code` block, an empty code block remains in the DOM. This commit removes empty inline code blocks on normalize. Steps to reproduce: - Create a list - Type some inline code - Put the cursor in the middle - Press Enter - Type some text after the inline code on the second line - Try to remove the inline code from the second line using backspace => The line is removed before the code style disappears task-5375140 closes odoo#243424 X-original-commit: 352a29f Part-of: odoo#240805 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
…ployee Currently, an error occurs when a user creates an attendance for an employee. Steps to Reproduce: - Install the hr_attendance module. - Go to Overtime Rulesets and create a new overtime ruleset by adding an overtime rule. Set Based on to Timing. Set the Start time greater than the Stop time (ex, Start = 10 and Stop = 5). - Go to Employees, open any employee record, and assign this Overtime Ruleset to the employee. - Now go to Attendances and create an attendance for that employee. TypeError: '>' not supported between instances of 'datetime.datetime' and 'int' This error occurs when a user sets the overtime rule on an employee and then creates an attendance. At that point, the system tries to calculate the overtime intervals based on the timing rule. Because the rule’s start time is greater than the stop time, it attempts to calculate the interval for the remaining working period of the day. However, the start date and end date are calculated in datetime format [1], while integer and float values are passed as arguments [2] for day in interval calulation. Since the interval expects values of the same data type, than it raise the error [3]. This commit ensures that the day start and day end values are passed in datetime format. [1]: https://github.com/odoo/odoo/blob/67191cf0915081df352331a698be47b7e3ecd505/addons/hr_attendance/models/hr_attendance_overtime_rule.py#L524 [2]: https://github.com/odoo/odoo/blob/67191cf0915081df352331a698be47b7e3ecd505/addons/hr_attendance/models/hr_attendance_overtime_rule.py#L530 [3]: https://github.com/odoo/odoo/blob/67191cf0915081df352331a698be47b7e3ecd505/odoo/tools/intervals.py#L138-L154 sentry-7166788786 closes odoo#243266 X-original-commit: a7c39a6 Signed-off-by: Mélanie Peyrat (mepe) <mepe@odoo.com> Signed-off-by: Ashutosh Sharma (assh) <assh@odoo.com>
Previously, the invoice label was always displayed as “Tax Invoice” or “Invoice” However, as per Section 31 of the CGST Act, the document label must depend on the nature of supplies and the customer type: - If the document contains only taxable supplies => “Tax Invoice” - If the document contains only exempt supplies => “Bill of Supply” - If the customer is unregistered and the document contains both taxable and exempt supplies => “Invoice-cum-Bill of Supply” - If the customer is registered and the document contains both taxable and exempt supplies, separate documents must be issued as per the law. With this commit, the invoice label is generated strictly in accordance with Section 31 of the CGST Act. In the case of a registered customer where both taxable and exempt supplies exist in a single document, the label will be printed as “Invoice”. task-5468323 closes odoo#243436 X-original-commit: 52b2434 Signed-off-by: Josse Colpaert (jco) <jco@odoo.com> Signed-off-by: Jay Savaliya (jasa) <jasa@odoo.com>
**Steps to reproduce:** * Install the **stock** and **sale_management** modules. * Go to *Inventory > Configuration > Attributes* and create a new attribute. * Set *Variant Creation Mode* to *Never*. * Add a single attribute value and enable *Free text* on it. * Create a product using this attribute and select the value for which *free text* is enabled. * Create a Sale Order for this product. * Open the sale order line pop-up and enter custom text in the *Text* field. * Confirm the sale order. * Open the generated Delivery Order. *Observed behavior:* The product name appears twice in the stock move description. The same duplication appears in the Delivery Slip PDF report. *Cause:* In `_compute_description_picking`, the description is built as description + variant description. Since Odoo already uses the product name as the base description and avoids rendering it twice only when the name equals the description, concatenating the variant description breaks this logic and results in the product name being repeated. opw-5382353 closes odoo#243414 X-original-commit: 105fec2 Signed-off-by: Lancelot Semal (lase) <lase@odoo.com> Signed-off-by: Pawan Kumar Gupta (pkgu) <pkgu@odoo.com>
When the call control overlay is floating, it overlaps the fullscreen button, making it difficult to enter fullscreen mode. This commit ensures the fullscreen action remains accessible by adjusting the layout layering so controls no longer overlap each other. Task-5240896 closes odoo#243446 X-original-commit: 241e747 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Nitant Makwana (nmak) <nmak@odoo.com>
Before this commit: - All website product categories were always displayed under the main /shop page. - There was no way to exclude a category from the shop hierarchy. - This prevented creating standalone product category pages or curated product selections that should not appear in the main shop view. After this commit: - Added a boolean field to hide specific categories from the /shop structure. - Hidden categories remain fully functional and can be accessed directly through their URLs and 'Go to website' stat button in their form view. - Redesigned the eCommerce Category form view. task-5129498 closes odoo#231049 Signed-off-by: Shrey Mehta (shrm) <shrm@odoo.com>
* = sa, eg, pk, ae This commit adds the remaining descriptions and their translations to the expense accounts in the Chart of Accounts for Saudi Arabia, Pakistan, Egypt, and the United Arab Emirates. task - 5039719 closes odoo#238616 Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Part-of: odoo#243316 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
closes odoo#243316 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
### Contains the following commits: odoo/o-spreadsheet@e5cbf1807 [REL] 19.2.0-alpha.3 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) odoo/o-spreadsheet@c206f46b4 [FIX] Pivots: Recompute measure on indirect dependency update [Task: 5349782](https://www.odoo.com/odoo/2328/tasks/5349782) odoo/o-spreadsheet@c1c00f4d9 [IMP] pivots: implement pivot table styles [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@fcdef4757 [IMP] renderer: draw cell background over grid lines [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@a865dbf2c [IMP] style: add `skipCellGridLines` style option [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@86856abfd [REF] table style: add `bold` to table style presets [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@351919f8f [REF] subtotal: extract SUBTOTAL tracking to generic plugin [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@4dee81dbe [IMP] Added some shortcuts [Task: 5231802](https://www.odoo.com/odoo/2328/tasks/5231802) odoo/o-spreadsheet@c7180d1f7 [FIX] tests: fix useless shortcuts tests [](https://www.odoo.com/odoo/2328/tasks/) odoo/o-spreadsheet@a30272f1f [IMP] Autocompletion of curly brackets {} [](https://www.odoo.com/odoo/2328/tasks/) odoo/o-spreadsheet@21e3d6155 [FIX] f&r: the searched range should follow the active sheet [Task: 5423885](https://www.odoo.com/odoo/2328/tasks/5423885) odoo/o-spreadsheet@20ee28aac [IMP] figure: add data-type attribute to figure carousel tabs [Task: 5447027](https://www.odoo.com/odoo/2328/tasks/5447027) odoo/o-spreadsheet@abb24152c [FIX] Style: UPDATE_CELL overwrites the cell style [Task: 5441149](https://www.odoo.com/odoo/2328/tasks/5441149) odoo/o-spreadsheet@a4792e26f [FIX] tests: fix network serialization in mock [Task: 5441149](https://www.odoo.com/odoo/2328/tasks/5441149) odoo/o-spreadsheet@ea607f07d [IMP] formulas: add spilled range operator [Task: 5365642](https://www.odoo.com/odoo/2328/tasks/5365642) odoo/o-spreadsheet@3b6e45921 [IMP] style: check if default but faster [Task: 5431688](https://www.odoo.com/odoo/2328/tasks/5431688) odoo/o-spreadsheet@abeea3e5d [FIX] Composer: Capture the correct selection on `F2` [Task: 5462713](https://www.odoo.com/odoo/2328/tasks/5462713) odoo/o-spreadsheet@7c556a916 [REF] lint: enforce braces for all control statements [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) Part-of: odoo#243762 Related: odoo/enterprise#104267 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Florian Damhaut (flda) <flda@odoo.com> Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Ronak Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com> Co-authored-by: Marceline Thomas (matho) <matho@odoo.com>
With this commit, we don't need to manually create a dynamic table to a pivot to have a style applied. Instead we can add a style in the pivot definition, and dynamic tables will automatically be created on the dynamic pivot formulas. Those new pivot styles are better than traditional tables styles because: - they are directly linked to the pivot, taking into account the number of headers, the presence of totals, etc. - they are automatically added on `=PIVOT()` formulas, without the need to create a dynamic table first. - they are more powerful than the old table styles, they can have a style for the sub-headers, the measure headers, etc. Task: 4552232 Part-of: odoo#243762 Related: odoo/enterprise#104267 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
### Contains the following commits: odoo/o-spreadsheet@e5cbf1807 [REL] 19.2.0-alpha.3 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) odoo/o-spreadsheet@c206f46b4 [FIX] Pivots: Recompute measure on indirect dependency update [Task: 5349782](https://www.odoo.com/odoo/2328/tasks/5349782) odoo/o-spreadsheet@c1c00f4d9 [IMP] pivots: implement pivot table styles [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@fcdef4757 [IMP] renderer: draw cell background over grid lines [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@a865dbf2c [IMP] style: add `skipCellGridLines` style option [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@86856abfd [REF] table style: add `bold` to table style presets [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@351919f8f [REF] subtotal: extract SUBTOTAL tracking to generic plugin [Task: 4552232](https://www.odoo.com/odoo/2328/tasks/4552232) odoo/o-spreadsheet@4dee81dbe [IMP] Added some shortcuts [Task: 5231802](https://www.odoo.com/odoo/2328/tasks/5231802) odoo/o-spreadsheet@c7180d1f7 [FIX] tests: fix useless shortcuts tests [](https://www.odoo.com/odoo/2328/tasks/) odoo/o-spreadsheet@a30272f1f [IMP] Autocompletion of curly brackets {} [](https://www.odoo.com/odoo/2328/tasks/) odoo/o-spreadsheet@21e3d6155 [FIX] f&r: the searched range should follow the active sheet [Task: 5423885](https://www.odoo.com/odoo/2328/tasks/5423885) odoo/o-spreadsheet@20ee28aac [IMP] figure: add data-type attribute to figure carousel tabs [Task: 5447027](https://www.odoo.com/odoo/2328/tasks/5447027) odoo/o-spreadsheet@abb24152c [FIX] Style: UPDATE_CELL overwrites the cell style [Task: 5441149](https://www.odoo.com/odoo/2328/tasks/5441149) odoo/o-spreadsheet@a4792e26f [FIX] tests: fix network serialization in mock [Task: 5441149](https://www.odoo.com/odoo/2328/tasks/5441149) odoo/o-spreadsheet@ea607f07d [IMP] formulas: add spilled range operator [Task: 5365642](https://www.odoo.com/odoo/2328/tasks/5365642) odoo/o-spreadsheet@3b6e45921 [IMP] style: check if default but faster [Task: 5431688](https://www.odoo.com/odoo/2328/tasks/5431688) odoo/o-spreadsheet@abeea3e5d [FIX] Composer: Capture the correct selection on `F2` [Task: 5462713](https://www.odoo.com/odoo/2328/tasks/5462713) odoo/o-spreadsheet@7c556a916 [REF] lint: enforce braces for all control statements [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) closes odoo#243762 Related: odoo/enterprise#104267 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Florian Damhaut (flda) <flda@odoo.com> Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Ronak Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com> Co-authored-by: Marceline Thomas (matho) <matho@odoo.com>
Xendit has expanded to TH, MY and VN supporting the local payment channels. This commit is to add the supported pamyent channels according to what they have added. task-4334511 closes odoo#243722 X-original-commit: bda8d97 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Nigel Nicholas (nni) <nni@odoo.com>
**Steps to reproduce:** * Create an **employee** with a bank account. * Link the employee’s contact to the current company as a **child partner**. * Create an expense for that employee with payment mode **Paid by Employee**. * Submit, approve, and post the expense. * Open the **payment register** to reimburse the employee. **Observed behavior:** * The payment register defaults to the **company bank account** instead of the employee’s bank account. **Cause:** * The `account_payment_registered` file was removed in this commit: odoo@704a5a1#diff-f8829ed273c0ec8838636b1709ac4f895857992dddada6dbcbca3c62a2cbce81 * As a result, the payment register no longer prioritizes the employee’s bank account when the employee contact is linked to the company. **Fix:** * Added `account_register_payment` back to the `__init__` file. opw-5414133 closes odoo#243632 X-original-commit: e5e056a Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Steps to reproduce: =================== - Go to website sale & pick any product. - Go to edit mode & drop a popup in the product description -> Popup appear behind of the product image. Cause: ===== Product popups inserted inside the description column (#product_details) inherit it's z-index, while the adjacent .o_wsale_product_images column stays with z-index: 1. Since the details column z-index: 0, any popup inside it remained under the image column. Solution: ========= Override the z-index only when a popup is present opw-5458436 closes odoo#243736 X-original-commit: ab7615d Signed-off-by: Lina Eweis (liew) <liew@odoo.com>
Problem: Add a link as the first line in a todo and refresh the page. The link is highlighted as soon as the page loads, even though no selection was made by the user. Cause: After 880734e, when the editor is loaded without an active selection, the selection is set to the first element in the editable. If that element is a link, the class `o_link_in_selection` is added automatically. Solution: Only add `o_link_in_selection` when the selection is on a link and the editable is focused. Steps to reproduce: - Open a Todo. - Add a link as the first text. - Refresh the page. - Observe the link is highlighted. task-5436106 closes odoo#243741 X-original-commit: fe66355 Related: odoo/enterprise#104258 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Walid Sahli (wasa) <wasa@odoo.com>
Before this commit, if a loyalty program had pricelist restrictions, the POS would not consider them when loading the applicable loyalty programs. This could lead to scenarios where a loyalty program was applied in a POS session even if the session's pricelist was not allowed by the program. This happened when the pricelist was also not available in the POS configuration and program.pricelist_ids was empty. opw-5467990 closes odoo#243724 X-original-commit: 1592b15 Signed-off-by: David Monnom (moda) <moda@odoo.com> Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
author_id expects a res.partner record. In this commit: Replace the user record with the corresponding partner record to avoid passing an incorrect recordset in demo data. closes odoo#243732 X-original-commit: 4212f10 Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
This commit converts field `Store.isNotificationPermissionDismissed`
to simpler syntax `{ localStorage: true }`.
As the key changes, this also adds upgrade script to preserve the
setting.
closes odoo#243612
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
**Steps to reproduce** On a local DB, with demo data: - Change your machine's time to a late part of the day (e.g. 6pm) - Install `mrp_workorder` - Set the "Standard 40 hours/week" (used by a workcenter) as flexible. - From the Shop Floor, start the "WH/MO/00003 - Manual Assembly" workorder. "Validation Error: The start date of the time off must be earlier than the end date." **Cause** `_calculate_date_finished` in mrp is calling `plan_hours` and under certain conditions with a flexible resource, it is possible for `plan_hours` to return a datetime before the `day_dt` parameter. This happens because for flexible resources, `_attendance_intervals_batch` can return attendance intervals with start or end datetimes outside of the start_dt -> end_dt window. For example, a flexible calendar with 8h/day will return the 8:00->16:00 interval, even if start_dt is later than 8:00. **Change** Don't return attendance intervals outside of the [start_dt, end_dt] interval by shifting them if necessary. opw-5123230 closes odoo#243544 X-original-commit: 9f4ac8e Signed-off-by: Tanguy Quéguineur (taqu) <taqu@odoo.com> Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
The aim of this commit is to fix the commercial partner id of the move lines to default to the move's partner commercial partner Steps to reproduce: - Have a bank account setup for the current company - Create an employee for a user, sets its `parent_id` to be the current company and set a bank account on the employee - Create an expense for said employee in `own_account` - Submit -> Pay flow - Bank account on the wizard is the company one, not the employee one After this commit: - Bank account on the wizard is the employee one, we stop pretending to reimburse them and actually give them money closes odoo#243609 Task-id: 5420587 X-original-commit: 97bc3a1 Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Julien Alardot (jual) <jual@odoo.com>
With commit 19302cd, when a page is created, menu entries with a url corresponding to the created page are updated to set their `page_id` to the new page. The update may also be triggered when creating several pages with the same name. This commit updates a menu entry on page creation only if no page were already associated to the menu. Steps to reproduce: - Create a new page, call it "test" (will be available on `/test`) - Create a new page, call it "test" (will be available on `/test-1`) - Go to editor menu - Bug: both entries point to `/test-1` - Create a new page, call it "test" (will be available on `/test-2`) - Go to editor menu - Bug: the first one (and the new one) is pointing now to `/test-2` task-5186653 closes odoo#243764 X-original-commit: 70dd6b6 Signed-off-by: Robin Lejeune (role) <role@odoo.com> Signed-off-by: Sébastien Blondiau (blse) <blse@odoo.com>
group commands, rsync only once. closes odoo#243796 Signed-off-by: Max Whale (mawh) <mawh@odoo.com>
Issue: Reverse moves miss `invoice_origin` field. To reproduce: 1- Create a SO. 2- Create an invoice and confirm. 3- In invoice list view make the `Source Document` visible. 4- Create a credit note and reverse the move. From invoice list view, you can observe that `Source Document` is empty for reverse move. Cause: This is a regression introduced by odoo#236656. opw-5362055 closes odoo#243738 X-original-commit: c094b08 Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Mohammadmahdi Alijani (malj) <malj@odoo.com>
Issue:
Purchasing a Kit and validating the receipt sets the value of the pol to
all the exploded kit moves. It should rather explode that valuation by
taking care of the defined and undefined cost_share as well as the kit
proportions.
Steps to reproduce:
- Create a kit product with 2 bom lines:
- 1 x COMP1, cost_share: 20%
- 2 X COMP2, cost_share: 80%
- Create and confirm a PO for 1 x your kit prodcut for 1000$
- Validate the receipt
> Both moves are valued as 1000$
opw-4806023
X-original-commit: c285ec8
Part-of: odoo#243165
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Lancelot Semal (lase) <lase@odoo.com>
…iants Issue: The cost_share of a bom corresponding to a given variant should sum up to 100% and the valuation of kit product via a purchase order should be distributed amoungst its exploded moves. Currently, the constraint is that the sum of all cost_share's used on the bom sum up to 100%: https://github.com/odoo/odoo/blob/7038c786ff0da782dd1895f124c272d5617379fc/addons/purchase_mrp/models/mrp_bom.py#L12-L22 and if not all lines are used by a product variant it value will be lost in the process. Steps to reproduce: - Create a bom: - 1 X COMP1 cost share 50% - 1 X COMP2 cost_share 50% for White - 1 X COMP3 cost share 50% for Black > User error: The total cost share for a BoM's component have to be 100 opw-4806023 closes odoo#243165 X-original-commit: ce20630 Signed-off-by: William Henrotin (whe) <whe@odoo.com> Signed-off-by: Lancelot Semal (lase) <lase@odoo.com>
Steps to reproduce ------------------ 1. Set the PoS taxes display to tax-included 2. In PoS, add a product, change its quantity to 2, and change its price too Notice that the new price / unit is shown as price excluded, even though we set the prices to tax-included in the PoS settings. Reason ------ We were using the getter `currencyDisplayPriceUnit` which uses `displayPriceUnit` which always shows the price as `tax_exluded`. Fix --- Now we change `displayPriceUnit` to adapt to the `iface_tax_included` config in PoS. That follows well the convention used for the non-unit price getter, `displayPrice`. For the cases where we want to explicitly use the tax excluded unit price, we have created the getters `displayPriceUnitExcl` and `currencyDisplayPriceUnitExcl` for that, which replaces some usages of the old getters. opw-5405572 X-original-commit: 926e7a4 Part-of: odoo#243810 Related: odoo/enterprise#104309 Signed-off-by: David Monnom (moda) <moda@odoo.com> Signed-off-by: Hadi El Yakhni (hael) <hael@odoo.com>
We were mistakenly doing `str - number` in 9538698. We fix that now, by following what was done before the beformentioned commit. See: https://github.com/odoo/odoo/blob/7f20097575dde3d9d73c3b84b77ee82ead53d68e/addons/point_of_sale/static/src/app/models/pos_order.js#L645-L646. closes odoo#243810 X-original-commit: abb0b88 Related: odoo/enterprise#104309 Signed-off-by: David Monnom (moda) <moda@odoo.com> Signed-off-by: Hadi El Yakhni (hael) <hael@odoo.com>
To reproduce: install hr_payroll open an employee form view > payroll make sure the employee_version you are on doesn't have a contract end date set the end date to X and without saving create a new employee version from the plus sign with date greater than X The Bug: when following the above flow a contract will be created for both employee versions it shouldn't be the case for the second version as version date is greater than contract end date opw-5427769 closes odoo#243326 X-original-commit: dbda8f7 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
task-5436779
|
This PR targets the un-managed branch odoo-dev/odoo:master-ruff-anv, it needs to be retargeted before it can be merged. |
|
This PR targets the un-managed branch odoo-dev/odoo:master-ruff-anv, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-5436779
See also: