[FIX] give all arguments to Editor to be able to use them#3
Open
[FIX] give all arguments to Editor to be able to use them#3
Conversation
Before this commit: Overriding the `EditorCommand` to add new parameters/arguments to the command would work. But it would not be accessible from `Editor` class as only the `repository` was given from the args After this commit: Forward to the `Editor` all commands arguments ! This is potentially unstable if `__init__` is overridden by `Editor` subclasses
lse-odoo
force-pushed
the
main-imp_allow_editor_child_access_command-lse
branch
from
744fd55 to
4765d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this commit:
Overriding the
EditorCommandto add new parameters/arguments to the command would work. But it would not be accessible fromEditorclass as only therepositorywas given from the argsAfter this commit:
Forward to the
Editorall commands arguments! This is potentially unstable if
__init__is overridden byEditorsubclassesLinked Issues
Link the issues that this PR solves, if any: Nope!
Compliance
docsdirectoryrequirements.txtfile, if any