Skip to content

[FIX] Selection of specific commit SHA in worktree checkout/creation#118

Merged
brinkflew merged 1 commit intobetafrom
avs-git-revision-hash
Dec 22, 2025
Merged

[FIX] Selection of specific commit SHA in worktree checkout/creation#118
brinkflew merged 1 commit intobetafrom
avs-git-revision-hash

Conversation

@brinkflew
Copy link
Contributor

We were prepending origin/ in front of the commit SHA when selecting a specific commit. While this helps with branches that are on the remote but not fetched locally, this made it impossible to select a commit.

This commit fixes the issue by removing the origin/ prefix when the checked out revision is a commit SHA.

Compliance

  • I have read the contribution guide
  • I made sure the documentation is up-to-date both in doctrings and the docs directory
  • I have added or modified unit tests where necessary
  • I have added new libraries to the requirements.txt file, if any
  • I have incremented the version number according the versioning guide
  • The PR contains my changes only and no other external commit

@brinkflew brinkflew self-assigned this Dec 4, 2025
@brinkflew brinkflew added the bug Something isn't working label Dec 4, 2025
@brinkflew brinkflew changed the base branch from main to beta December 11, 2025 15:18
@brinkflew brinkflew marked this pull request as ready for review December 11, 2025 15:19
@brinkflew brinkflew requested a review from sea-odoo December 11, 2025 15:19
sea-odoo
sea-odoo previously approved these changes Dec 14, 2025
Base automatically changed from beta to main December 19, 2025 12:16
@brinkflew brinkflew dismissed sea-odoo’s stale review December 19, 2025 12:16

The base branch was changed.

We were prepending `origin/` in front of the commit SHA when selecting
a specific commit. While this helps with branches that are on the remote
but not fetched locally, this made it impossible to select a commit.

This commit fixes the issue by removing the `origin/` prefix when
the checked out revision is a commit SHA.
@brinkflew brinkflew force-pushed the avs-git-revision-hash branch from dd2f8a1 to 5d2d2c7 Compare December 22, 2025 08:50
@brinkflew brinkflew changed the base branch from main to beta December 22, 2025 08:50
@brinkflew brinkflew merged commit 5d2d2c7 into beta Dec 22, 2025
5 checks passed
@brinkflew brinkflew deleted the avs-git-revision-hash branch December 22, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants