Skip to content

Conversation

@ofek
Copy link
Owner

@ofek ofek commented Jun 11, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ofek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the core conversion logic to perform floor division when explicitly converting a value to bytes. This change ensures that the result for the smallest unit (bytes) is an integer. Alongside this core change, I've updated the relevant tests and documentation, including the README badges and changelog.

Highlights

  • Core Logic Change: I've updated the convert_units function in binary/core.py to use floor division (//) specifically when the target unit (to) is BYTE. This ensures that conversions to the smallest unit result in an integer value.
  • Test Updates: I've adjusted the expected values in the TestConvertFloatExact.test_byte test case in tests/test_core.py to match the new floor division behavior, asserting against Decimal values without fractional parts.
  • Documentation & Maintenance: I've updated various badges in the README (GitHub Actions, License, added Sponsors), removed some potentially outdated installation description text, and added a changelog entry for the upcoming 1.0.2 release documenting this floor division change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the conversion logic to use floor division when explicitly converting to bytes, ensuring integer results for byte quantities. It also updates README badges and adds a changelog entry for the new version.

binary/core.py Outdated
Comment on lines 168 to 171
if to == BYTE:
return b // to, PREFIXES[to]
else:
return b / to, PREFIXES[to]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic now explicitly uses floor division (//) when the target unit (to) is BYTE. This aligns with the pull request title and ensures that conversions resulting in bytes yield an integer quantity, which is typically expected for byte counts.

@ofek ofek merged commit adc81c1 into master Jun 11, 2025
22 checks passed
@ofek ofek deleted the bytes branch June 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants