-
Notifications
You must be signed in to change notification settings - Fork 4
Perform floor division when explicitly converting to bytes #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ofek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modifies the core conversion logic to perform floor division when explicitly converting a value to bytes. This change ensures that the result for the smallest unit (bytes) is an integer. Alongside this core change, I've updated the relevant tests and documentation, including the README badges and changelog.
Highlights
- Core Logic Change: I've updated the
convert_unitsfunction inbinary/core.pyto use floor division (//) specifically when the target unit (to) isBYTE. This ensures that conversions to the smallest unit result in an integer value. - Test Updates: I've adjusted the expected values in the
TestConvertFloatExact.test_bytetest case intests/test_core.pyto match the new floor division behavior, asserting againstDecimalvalues without fractional parts. - Documentation & Maintenance: I've updated various badges in the README (GitHub Actions, License, added Sponsors), removed some potentially outdated installation description text, and added a changelog entry for the upcoming 1.0.2 release documenting this floor division change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the conversion logic to use floor division when explicitly converting to bytes, ensuring integer results for byte quantities. It also updates README badges and adds a changelog entry for the new version.
binary/core.py
Outdated
| if to == BYTE: | ||
| return b // to, PREFIXES[to] | ||
| else: | ||
| return b / to, PREFIXES[to] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.