Attempt to ensure that alt+f4 hides the window instead of closing application#6
Open
ashleygrobler04 wants to merge 1 commit intoogomez92:mainfrom
Open
Attempt to ensure that alt+f4 hides the window instead of closing application#6ashleygrobler04 wants to merge 1 commit intoogomez92:mainfrom
ashleygrobler04 wants to merge 1 commit intoogomez92:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aimbs to fix one of the issues in the readme, where alt+f4 closes the application entirely instead of just hiding it like it should.
With this commit, I've tested that alt+f4 hides the application and it does so well.
The only issue I could manage to encounter thus far is the sound for hiding does not play when you do press alt+f4, but other than that, this works.
Hope to have this added into this awesome application!