Skip to content

Added a little adp-connect debugging. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikogan merged 1 commit into from
Nov 4, 2025
+1 −0
Merged

Added a little adp-connect debugging. #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions adp-connect.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,7 @@ if [[ ! "${ONLY_DOWNLOAD}" = "true" ]]; then
for CLUSTER in $(rancher cluster list | grep -v CURRENT | sed 's/^*//g' | awk '{ print $1 }'); do
if [[ -z "${SKIP_KUBECONFIG}" ]]; then
TEMP_KUBE_CONFIG=$(echo "${SERVER}-${CLUSTER}" | base64)
debug "Fetching kubeconfig for cluster ${CLUSTER} on server ${SERVER}..."
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug message on line 807 duplicates information already shown by the gum spin title on line 808. When HAVE_GUM is true and ENABLE_DEBUG is set, users will see both messages simultaneously, which is redundant. The debug message should either provide additional context (like the full file path where the config will be saved) or be removed to avoid duplication.

Suggested change
debug "Fetching kubeconfig for cluster ${CLUSTER} on server ${SERVER}..."
debug "Fetching kubeconfig for cluster ${CLUSTER} on server ${SERVER} (saving to ${TEMP_DIR}/${TEMP_KUBE_CONFIG}.yaml)..."

Copilot uses AI. Check for mistakes.
gum spin --show-error --title="Fetching kubeconfig for cluster ${CLUSTER}..." -- rancher cluster kf "${CLUSTER}" > "${TEMP_DIR}/${TEMP_KUBE_CONFIG}.yaml"
KUBE_CONFIGS+=("${TEMP_DIR}/${TEMP_KUBE_CONFIG}.yaml")
fi
Expand Down
Loading