Merged
Conversation
Ports changes made against the latest version of the specification to consolidate the JSON test using the JSON schema test suite format
joshmoore
approved these changes
May 13, 2022
Member
joshmoore
left a comment
joshmoore
left a comment
There was a problem hiding this comment.
Looks good and generally fine to get this in ASAP and iterate. As with #118 though, I still keep wondering if the test code shouldn't be in a usable library. Conceivably even the duplicated test suites could be shared at the top-level to prevent copy-n-paste but that perhaps is more confusing than it's worth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports changes made against the latest version of the specification to consolidate the JSON test using the JSON schema test suite format
See #118 for the corresponding PR against
latest