Clarify types and requirements levels for the plate/well specification#126
Merged
Clarify types and requirements levels for the plate/well specification#126
Conversation
This commit rewrites the section and ensures that: - each key has a requirement level specified as MUST/SHOULD/MAY - the type for the value of each key is explicitly defined
melissalinkert
requested changes
May 26, 2022
Member
melissalinkert
left a comment
melissalinkert
left a comment
There was a problem hiding this comment.
Super pedantic comments aside (some of which are things not introduced by this PR), this does read better than before.
Member
Author
|
Thanks for the thorough review @melissalinkert. Pedantic comments are very useful. The aim of this PR is to reduce the ambiguity in the definition of these specifications. Pushed a few commits addressing your suggestions and adding the acquisition description to the JSON schema. I also ported the same text to the |
melissalinkert
approved these changes
May 27, 2022
Member
melissalinkert
left a comment
melissalinkert
left a comment
There was a problem hiding this comment.
Just a couple of typos left, 👍 once those are fixed.
github-actions bot
added a commit
that referenced
this pull request
May 30, 2022
…ion_2 Clarify types and requirements levels for the plate/well specification SHA: e26e206 Reason: push, by @joshmoore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit rewrites the section and ensures that:
The requirements & types should match the JSON schemas introduced in #120
Staged at http://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/sbesson/ngff/plate_specification_2/0.4/index.bs#plate-md