Draft
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
alexdewar
reviewed
Feb 14, 2025
Collaborator
alexdewar
left a comment
There was a problem hiding this comment.
Hi @jmp111,
To make the tests pass, you'll also need to update the config files for the integration test, then we can also review those changes as part of this PR.
Also, looking at the diff, git seems to think every line has been changed, which is usually a sign that line endings have been changed from Unix-style (LF) to Windows-style (CRLF) or vice versa. For more info, see: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings
Collaborator
|
@jmp111 Should this PR be marked as a draft and put on the backlog for now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TeamTat uses the infons type to show different types of formatting. Add in the types for current BioC files (document title, passages, and references) that will render in TeamTat.
This will cause failed tests as the resulting files will differ.
Type of change
Key checklist
pytest)mkdocs)pre-commit run --all-files)Further checks