Skip to content

Comments

Add in infons.type for passages#111

Draft
jmp111 wants to merge 6 commits intomainfrom
hackathon-passagetype
Draft

Add in infons.type for passages#111
jmp111 wants to merge 6 commits intomainfrom
hackathon-passagetype

Conversation

@jmp111
Copy link
Contributor

@jmp111 jmp111 commented Feb 14, 2025

Description

TeamTat uses the infons type to show different types of formatting. Add in the types for current BioC files (document title, passages, and references) that will render in TeamTat.

This will cause failed tests as the resulting files will differ.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. pytest)
  • The documentation builds and looks OK (eg. mkdocs)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

@jmp111 jmp111 requested a review from Antoinelfr February 14, 2025 12:09
@jmp111 jmp111 marked this pull request as ready for review February 14, 2025 12:32
@jmp111 jmp111 added enhancement New feature or request help wanted Extra attention is needed python Pull requests that update Python code labels Feb 14, 2025
Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmp111,

To make the tests pass, you'll also need to update the config files for the integration test, then we can also review those changes as part of this PR.

Also, looking at the diff, git seems to think every line has been changed, which is usually a sign that line endings have been changed from Unix-style (LF) to Windows-style (CRLF) or vice versa. For more info, see: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

@AdrianDAlessandro
Copy link
Collaborator

@jmp111 Should this PR be marked as a draft and put on the backlog for now?

@AdrianDAlessandro AdrianDAlessandro marked this pull request as draft March 24, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants