Merged
Conversation
This was referenced Dec 9, 2022
Merged
Member
|
Thanks for the demo yesterday (and last week too!) I can assign a reviewer and add this to the backlog to track on the main kanban. I know you had some questions about the process, and believe you all intend to discuss them during today's meeting, but feel free to update any changes in the comments. |
345f526 to
fd5a6a7
Compare
fd5a6a7 to
a28ec04
Compare
a28ec04 to
baa6b7e
Compare
RangerMauve
approved these changes
Dec 29, 2022
RangerMauve
left a comment
There was a problem hiding this comment.
This is great thank you for picking this up!
Member
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds OMI_collider. It supersedes #118. This PR takes #118, overhauls the text to be more readable, updates the table of equivalent types in major engines, adds some discussed features, fixes and completes the schema, and adds a folder of example GLTF files.
Preview: https://github.com/aaronfranke/gltf-extensions/tree/OMI_collider/extensions/2.0/OMI_collider
I have the document listed as a Stage 2 proposal. This PR meets all of the requirements of Stage 1 and Stage 2.
Stage 1
Stage 2
examples/subfolder)OMI_collider/README.mdfile in this PR)Stage 3