Allow shapes to be directly on bodies or indirect children/descendants#169
Merged
aaronfranke merged 1 commit intoomigroup:mainfrom Aug 10, 2023
Merged
Allow shapes to be directly on bodies or indirect children/descendants#169aaronfranke merged 1 commit intoomigroup:mainfrom
aaronfranke merged 1 commit intoomigroup:mainfrom
Conversation
This was referenced Jun 7, 2023
Member
|
We're going to make a change to OMI_collider to not have default behavior so that implementing deeply nested colliders does not require traversing the ancestors of a collider to determine if it is the parent of a physics body or if it should have the default behavior of a collider without a physic body. |
Member
Author
|
The PR Robert mentions that changes it to not have default behavior is this one #171 |
aaronfranke
changed the title
aaronfranke
force-pushed
the
collider-loc
branch
from
24d3e4f to
604367a
Compare
aaronfranke
changed the title
aaronfranke
force-pushed
the
collider-loc
branch
from
604367a to
1546e3f
Compare
aaronfranke
force-pushed
the
collider-loc
branch
from
1546e3f to
79679f7
Compare
antpb
approved these changes
Aug 10, 2023
Contributor
antpb
left a comment
antpb
left a comment
There was a problem hiding this comment.
LGTM and approved in meeting on vote
Contributor
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on some ongoing discussion on converging the physics specs KhronosGroup/glTF#2258
I am still skeptical of the portability of having indirect children, but Eoin very strongly desires this feature, so I think it would make sense to allow it and just recommend direct children for those desiring a simple document structure. Conceptually speaking, there is no reason this can't be allowed, the only objections are implementation difficulty.
Existing OMI assets do not need to be updated, they are automatically compliant, this is a superset.
I also added a test file that tests every possible edge case of the relative placement and types of OMI_physics_shape and OMI_physics_body in the node hierarchy, so an implementation can test all of the edge cases at once.