[MIT-3253] Create Http interface for executing API request#178
Merged
Conversation
…lementation logic
new4762
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
More information
To make it easier to implement tests for API request, I did a quick update by extracting the executeCurl and executeTest to a new class with a new interface -
OmiseHttpExecutorInterface. The logic for both functions remain unchanged.API Mock Example
with Mockery:
Also, I update the unit test directory by moving all tests inside
unitfolder:Related links:
Rollback procedure
default rollback procedure