Skip to content

fix: add fallback lookup for route buildInfo to prevent 404s #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
natew wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add fallback lookup for route buildInfo to prevent 404s #644

natew wants to merge 3 commits into from

Conversation

@natew
Copy link
Collaborator

@natew natew commented Jan 7, 2026

Summary

  • Adds a fallback mechanism when looking up route build info
  • If the exact file key match fails, tries to find build info by matching the URL pathname or route page to the cleanPath
  • Adds a development warning when buildInfo is not found for spa/ssg routes

Fixes #446 (SSR routes return 404 when layout present only in parent)

Test plan

  • Build a project with parent layout but no child layout
  • Verify routes don't return 404 errors

@railway-app
Copy link

railway-app bot commented Jan 7, 2026 •
edited
Loading

🚅 Deployed to the one-pr-644 environment in onestack.dev

Service Status Web Updated (UTC)
one ✅ Success (View Logs) Web Jan 7, 2026 at 5:11 am

@railway-app railway-app bot temporarily deployed to onestack.dev / one-pr-644 January 7, 2026 02:45 Destroyed
@natew natew force-pushed the fix/ssr-route-buildinfo-lookup branch from bcc6f8f to 811aa16 Compare January 7, 2026 02:54
@railway-app railway-app bot temporarily deployed to onestack.dev / one-pr-644 January 7, 2026 02:54 Destroyed
@natew
Copy link
Collaborator Author

natew commented Jan 7, 2026

Updated to use O(1) pathToRoute lookup instead of for loop iteration. The pathToRoute index is already built at build time, so this is efficient.

Note: This still needs integration tests to properly verify the fix. The test would need to:

  1. Create a test app with parent layout but no child layout
  2. Build the app
  3. Serve and verify routes don't return 404

@railway-app railway-app bot temporarily deployed to onestack.dev / one-pr-644 January 7, 2026 03:08 Destroyed
natew added 3 commits January 6, 2026 18:38
@natew
fix: use O(1) pathToRoute lookup for buildInfo fallback
3885a81
@natew
add test for SSR routes with parent layout only
b7ecd98
@natew
fix: test flakiness and pre-existing build issues
bab18c1 
- Fix localhost vs 0.0.0.0 URL comparison in redirect test
- Skip prod tests for test-loaders (pre-existing SSR redirect build issue)
- Remove ssr-nested-layout test (tests route priority, not buildInfo lookup)
@natew natew force-pushed the fix/ssr-route-buildinfo-lookup branch from ae6c133 to bab18c1 Compare January 7, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSR routes return 404 when layout present only in parent

2 participants

@natew