FLIP 343: Fix numeric type rounding inconsistency#344
Merged
Conversation
6 tasks
SupunS
force-pushed
the
supun/update-numeric-rounding
branch
from
f25d5dc to
37028ac
Compare
turbolent
approved these changes
Aug 28, 2025
Member
turbolent
left a comment
turbolent
left a comment
There was a problem hiding this comment.
+1 from me
Though this is a backward incompatible change, the current behaviour is neither documented nor intended. I think it is more important to make the behaviour consistent than to keep backward compatibility for undefined behaviour.
1 task
joshuahannan
approved these changes
Sep 5, 2025
Member
Author
|
Thanks everyone for the feedback so far! This FLIP has been open for two weeks, and there hasn't been any feedback opposing this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: onflow/cadence#4172