Rollback and Snapshot support for remote storage#433
Open
bluesign wants to merge 10 commits intoonflow:masterfrom
Open
Rollback and Snapshot support for remote storage#433bluesign wants to merge 10 commits intoonflow:masterfrom
bluesign wants to merge 10 commits intoonflow:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 54.51% 53.90% -0.61%
==========================================
Files 27 27
Lines 3590 3651 +61
==========================================
+ Hits 1957 1968 +11
- Misses 1473 1522 +49
- Partials 160 161 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bluesign
requested review from
devbugging,
janezpodhostnik and
turbolent
as code owners
peterargue
approved these changes
Jun 26, 2023
Contributor
peterargue
left a comment
peterargue
left a comment
There was a problem hiding this comment.
This is awesome! Thanks for cleaning this up @bluesign
janezpodhostnik
requested changes
Jul 14, 2023
Contributor
janezpodhostnik
left a comment
janezpodhostnik
left a comment
There was a problem hiding this comment.
Nice work. Left one comment.
Collaborator
Author
|
@janezpodhostnik btw somehow archive node version switched stuff from Paths to Registers, and broke this, I can go over this PR or make a new one to fix |
bluesign
force-pushed
the
remoteRollbackAndSnap
branch
from
9f1dc3b to
9d1db68
Compare
Collaborator
Author
|
@peterargue can you help me with store_test? I tried but couldn't manage this fixture parts |
Collaborator
Author
|
I tried to fix this, but stuck again with some conflicts @sideninja archive, flow-go and contracts related. |
bluesign
force-pushed
the
remoteRollbackAndSnap
branch
from
bfa5e78 to
f73cb7b
Compare
bluesign
force-pushed
the
remoteRollbackAndSnap
branch
from
f73cb7b to
847b326
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added rollback and snapshot support for remote storage
Remote storage now can use any storage backend ( redid etc )
Added some sanity checks ( don't query blocks on archive after fork etc )
For contributor use:
masterbranchFiles changedin the GitHub PR explorer