Skip to content

go fix: remove obsolete +build directives#8422

Merged
tim-barry merged 1 commit intomasterfrom
tim/run-go1.26-fix
Feb 18, 2026
Merged

go fix: remove obsolete +build directives#8422
tim-barry merged 1 commit intomasterfrom
tim/run-go1.26-fix

Conversation

@tim-barry
Copy link
Contributor

@tim-barry tim-barry commented Feb 18, 2026

Run of go1.26.0 fix ./... on the flow-go repository.
Removes //+build directives, which have been deprecated since Go 1.18 (replaced by //go:build).

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated internal build configuration directives across multiple modules to use modern syntax. No changes to product functionality or user-facing features.

@tim-barry tim-barry requested a review from a team as a code owner February 18, 2026 21:23
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request removes legacy // +build directives from seven Go files while preserving the newer Go 1.17+ //go:build syntax. Build constraints are migrated to the modern single-line format across hash, WAL, and tools files with no functional code changes.

Changes

Cohort / File(s) Summary
Build Tools Configuration
admin/tools.go
Removed legacy // +build tools directive, retaining only the //go:build tools constraint.
Hash Function Build Constraints
ledger/common/hash/copy_generic.go, copy_unaligned.go, keccak.go, keccakf.go
Removed legacy // +build tags from four hash-related files; build constraints now rely solely on modern //go:build directives without functional code changes.
WAL File Advisory
ledger/complete/wal/fadvise.go, fadvise_linux.go
Removed legacy Linux build tag directives, migrating to modern //go:build syntax for platform-specific file handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • tarakby
  • peterargue
  • AlexHentschel

Poem

🐰 Old build tags were showing age,
Legacy marks upon the page,
Now go:build cleans the way,
Modern constraints save the day!
Hopping through the codebase bright,
Making everything just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing obsolete +build directives and consolidating to modern go:build syntax across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tim/run-go1.26-fix

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jordanschalm jordanschalm requested a review from tarakby February 18, 2026 21:38
@tim-barry tim-barry added this pull request to the merge queue Feb 18, 2026
Merged via the queue into master with commit 70b1145 Feb 18, 2026
61 checks passed
@tim-barry tim-barry deleted the tim/run-go1.26-fix branch February 18, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments