[opt:fuse_pad_into_conv] remove auto_pad, when use pads #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 462630221 <462630221@qq.com>
xiaobochen123
force-pushed
the
master
branch
from
0055f36 to
8f5a6e9
Compare
Member
|
Thanks! Could you please also check 'auto_pad' is 'NOTSET' at line 155? optimizer/onnxoptimizer/passes/fuse_pad_into_conv.h Lines 155 to 157 in 8f5a6e9 |
Member
|
@take-cheeze What is the status of this PR? Could it be merged or deleted? |
Member
|
@andife I feel @daquexian comment should be honered so made PR with test: #251 |
take-cheeze
added a commit
that referenced
this pull request
Jan 3, 2026
#33 --------- Signed-off-by: 462630221 <462630221@qq.com> Signed-off-by: take-cheeze <takechi101010@gmail.com> Co-authored-by: 462630221 <462630221@qq.com>
Member
|
Merged in #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.