Skip to content

Time inconsistencies heuristic for faulty measurements detection#147

Merged
LDiazN merged 30 commits intomainfrom
time-inconsistencies
Feb 19, 2026
Merged

Time inconsistencies heuristic for faulty measurements detection#147
LDiazN merged 30 commits intomainfrom
time-inconsistencies

Conversation

@LDiazN
Copy link
Contributor

@LDiazN LDiazN commented Feb 11, 2026

Implements an airflow dag that flags measurements with timestamp anomalies

closes #146

@LDiazN LDiazN requested a review from hellais February 11, 2026 14:57
@LDiazN LDiazN self-assigned this Feb 11, 2026
@LDiazN LDiazN changed the title Time inconsistencies Time inconsistencies heuristic for faulty measurements detection Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 97.45763% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.64%. Comparing base (e70e168) to head (32903ce).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...ine/src/oonipipeline/tasks/time_inconsistencies.py 87.50% 2 Missing ⚠️
oonipipeline/src/oonipipeline/tasks/volume.py 86.66% 2 Missing ⚠️
oonipipeline/tests/conftest.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   82.77%   83.64%   +0.86%     
==========================================
  Files          78       84       +6     
  Lines        4871     5104     +233     
==========================================
+ Hits         4032     4269     +237     
+ Misses        839      835       -4     
Flag Coverage Δ
oonidata 77.86% <ø> (ø)
oonipipeline 87.17% <97.45%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. Left a comment for what to improve in the threshold checks for measurements from time travelers

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for improvements. I think it's ok for us either deploying as-is and documenting this as future improvements or applying it pre-deploy

@hellais hellais self-requested a review February 19, 2026 10:49
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LDiazN LDiazN merged commit 5f6a53d into main Feb 19, 2026
9 checks passed
@LDiazN LDiazN deleted the time-inconsistencies branch February 19, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement time inconsistency heuristic task

2 participants

Comments