Merged
Conversation
andrewsy-opal
approved these changes
Sep 18, 2025
…of-disallowunknownfileds-in-generated-go-models Get rid of disallow unknown fields in generated go models
…used-files-in-go-sdk Cleanup Unused Files in the SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two braindead smoke tests that at least ensure that the SDK installs and doesn't contain duplicate files. Because the SDK is auto generated - it wouldn't really make a ton of sense to add a bunch of test cases for it. It works as long as the API works. However, the generated code can result in installation failures - so we need to quickly check for that.
Also got rid of the .idea/ and .ropeproject/ folders that seem to have been accidentally committed.