Cleanup Unused Files in the SDK#31
Merged
shrinjay-opal merged 3 commits intoshrinjay/opal-13634-add-installation-and-duplicate-files-smoke-testsfrom Sep 18, 2025
Conversation
andrewsy-opal
approved these changes
Sep 18, 2025
…of-disallowunknownfileds-in-generated-go-models Get rid of disallow unknown fields in generated go models
shrinjay-opal
merged commit da1c9d1
into
shrinjay/opal-13634-add-installation-and-duplicate-files-smoke-tests
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up some unused files and adds a script to do so which runs after each generation. The script just checks the FILES file that OpenAPI generator creates. This is because the openapi generator CLI does not handle this itself.
These unused files are not particularly problematic, but unused files can be problematic because they can contain broken-ness - for example we had a go file that was unused but contained duplicate definitions, resulting in the go SDK not building.