Addon certificate tracking and more addon status condition types#140
Addon certificate tracking and more addon status condition types#140yue9944882 wants to merge 1 commit intoopen-cluster-management-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
86c6b43 to
b797065
Compare
| Subject Subject `json:"subject,omitempty"` | ||
|
|
||
| // certificateStatus actively tracks the status of the certificate used by the addon. | ||
| CertificateStatus *RegistrationConfigCertificateStatus `json:"certificateStatus,omitempty"` |
There was a problem hiding this comment.
this field is only used for configuration of registration. I do not think we want to expose this field to addon when setting the configuration. Maybe we should move this out with the name of RegistrationStatuses?
There was a problem hiding this comment.
if we're moving this out, we will need an identifier field for each certificate status struct to correlate the status and registration config. i cant find such an identifier to use, otherwise we will need to duplicate the whole config. wdyt?
2ccc1cc to
6c045d4
Compare
Signed-off-by: yue9944882 <291271447@qq.com>
6c045d4 to
6fd8353
Compare
|
/hold backoff api-changes until the next release |
|
@yue9944882: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
RegistrationAppliedandManifestApplied