Add installStrategy for addon and upgrade to v1beta1#203
Add installStrategy for addon and upgrade to v1beta1#203qiujian16 wants to merge 2 commits intoopen-cluster-management-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
changed the title
qiujian16
force-pushed
the
addon-installstrategy
branch
from
4679786 to
2c5379c
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
addon-installstrategy
branch
from
2c5379c to
137e560
Compare
|
/lgtm |
For now we need to set storage of mca to v1alpha1, otherwise the installNamespace field will be lost Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
New changes are detected. LGTM label has been removed. |
qiujian16
changed the title
| type ManagedClusterAddOnSpec struct { | ||
| // configs is a list of add-on configurations. | ||
| // In scenario where the current add-on has its own configurations. | ||
| // An empty list means there are no defautl configurations for add-on. |
There was a problem hiding this comment.
An empty list means there are no owned configurations for add-on？
|
/hold |
| // +kubebuilder:default=open-cluster-management-agent-addon | ||
| // +kubebuilder:validation:MaxLength=63 | ||
| // +kubebuilder:validation:Pattern=^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ | ||
| RegistrationNamespace string `json:"registrationNamespace,omitempty"` |
There was a problem hiding this comment.
Not sure if using Namespace directly is better since it is in the RegistrationConfig struct.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Signed-off-by: Jian Qiu jqiu@redhat.com