Refactor SQL queries: enforce parameterized bindings and consistent style#49
Merged
Refactor SQL queries: enforce parameterized bindings and consistent style#49
Conversation
benwalch
reviewed
Feb 25, 2026
… enforce security measures, and clean up redundant code
benwalch
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit and cleanup of all raw SQL queries across the codebase (~114 query sites).
executeQuery()withexecuteStatement()for all DML (INSERT/UPDATE/DELETE)$db->quote()value embedding in favor of?/:nameparameter bindingsbuildConditionPartsFromDescriptor()to return[$conditions, $params]instead of inlining quoted valuessprintf()Deprecations
OpenDxp\Db\Helper::fetchPairs=> No replacementOpenDxp\Db\Helper::selectAndDeleteWhere=> No replacementOpenDxp\Db\Helper::quoteInto=> Use parameterized queries with ? or :name placeholders instead.