Add files for the Dockerfile and few modifications to the sol_got_ove…#51
Open
Bianca964 wants to merge 1 commit intoopen-education-hub:mainfrom
Open
Add files for the Dockerfile and few modifications to the sol_got_ove…#51Bianca964 wants to merge 1 commit intoopen-education-hub:mainfrom
Bianca964 wants to merge 1 commit intoopen-education-hub:mainfrom
Conversation
…rwrite.py for 02-rwslotmachine2 Signed-off-by: Bianca Ioana <biancaioana04@gmail.com>
razvand
requested changes
May 17, 2025
Contributor
razvand
left a comment
There was a problem hiding this comment.
Update your commit message. Use a prefix 02-rwslotmachine2: . Add a commit description. Follow instructions here.
Use a proper name for authoring and signing off the commit, i.e. use Bianca Farcasanu <biancaioana04@gmail.com> instead of Bianca Ioana <biancaioana04@gmail.com>.
Add a Makefile.sol that is used to build the binary. Copy that in the Dockerfile (as Makefile and run make in the Dockerfile instead of gcc.
Create two commits. One specific to the Dockerfile and one specific to the solution updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rwrite.py for 02-rwslotmachine2
Prerequisite Checklist
Description of changes