chapters/exploitation-techniques: Handle 07-challenge-shellcode-on-st…#56
Open
catalinamanolache wants to merge 3 commits intoopen-education-hub:mainfrom
Open
Conversation
…ack Docker setup and automation Added the following files to help with automation: 1. A Dockerfile containing two stages: build and runtime 2. A run.sh script which the student can run to handle the docker process 3. A README.md file which depicts the usage of the previous components. Signed-off-by: catalinamanolache <mmariacatalina@yahoo.com>
razvand
requested changes
May 17, 2025
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Simplify your commit prefix. Use only exploit-techniques: ....
Add ending newline.
Use present tense in commit description.
Use two commits. One for the solution and one for the Dockerfile in src/.
Use your proper name in the commit authorship and signature, i.e. use Cătălina Manolache <mmariacatalina@yahoo.com>, instead of catalinamanolache <mmariacatalina@yahoo.com>
...ters/exploitation-techniques/shellcodes/drills/07-challenge-shellcode-on-stack/sol/README.md
Outdated
Show resolved
Hide resolved
Updated the Dockerfile for the shellcode-on-stack challenge to properly build and run the vulnerable binary, ensuring it works correctly in the Docker environment and listens on port 31345. Signed-off-by: Cătălina Manolache <mmariacatalina@yahoo.com>
Added the following files: 1. A Makefile which the student can use to handle the docker process. 2. A README.md file which depicts the usage of the previous component. Signed-off-by: Cătălina Manolache <mmariacatalina@yahoo.com>
razvand
requested changes
May 17, 2025
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
One of your commits doesn't have the proper name. Use Cătălina Manolache <mmariacatalina@yahoo.com> instead of catalinamanolache <mmariacatalina@yahoo.com>.
Comment on lines
+21
to
+22
| The Makefile automates the process of building the Docker image, running the | ||
| container, copying the binary and executing the exploit script. |
Contributor
There was a problem hiding this comment.
Suggested change
| The Makefile automates the process of building the Docker image, running the | |
| container, copying the binary and executing the exploit script. | |
| The Makefile automates the process of building the Docker image, running the container, copying the binary and executing the exploit script. |
One sentence per line.
| # Cleanup: Remove the local copy of the binary and stop the container | ||
| rm -f vuln | ||
| docker stop challenge07 | ||
| docker rm -f challenge07 No newline at end of file |
| ENV TERM=xterm | ||
|
|
||
| COPY --from=builder /build/vuln /app/vuln | ||
| COPY sol/exploit.py /app/exploit.py |
Contributor
There was a problem hiding this comment.
Why do you copy the exploit?
| stop: | ||
| -docker stop $(CONT_NAME) 2>/dev/null || true | ||
| -docker rm -f $(CONT_NAME) 2>/dev/null || true | ||
| -rm -f ./vuln 2>/dev/null || true |
Contributor
There was a problem hiding this comment.
This line isn't required, is it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ack Docker setup and automation
Added the following files to help with automation:
Prerequisite Checklist
Description of changes