Skip to content

Conversation

@JamieSinn
Copy link
Contributor

@JamieSinn JamieSinn commented Jan 26, 2026

This PR

  • sets up a new repo to benchmark a shared evaluator
  • poc/temp for now

Related Issues

Related to benchmarking this concept: open-feature/flagd#1842

Notes

Follow-up Tasks

How to test

@JamieSinn JamieSinn requested review from a team as code owners January 26, 2026 15:13
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JamieSinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes the foundational configuration for a new repository, 'flagd-poc-benchmark', within the OpenFeature project structure. Its primary purpose is to prepare the environment for benchmarking 'flagd' and shared evaluation performance, ensuring the new repository is correctly recognized and categorized as a private proof-of-concept.

Highlights

  • New Repository Configuration: Added 'flagd-poc-benchmark' to the 'config/open-feature/flagd/workgroup.yaml' file, integrating it into the workgroup's repository list.
  • Organization Repository Definition: Defined 'flagd-poc-benchmark' in 'config/open-feature/org.yaml' with a description 'PoC Benchmarking for flagd and shared evaluation performance' and marked it as private.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: Jamie Sinn <james.sinn@dynatrace.com>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@toddbaert toddbaert merged commit 4da6b77 into open-feature:main Jan 26, 2026
1 check passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request sets up a new repository flagd-poc-benchmark for benchmarking purposes by updating the organization's configuration files. The changes are straightforward and correct. I've added one comment regarding list sorting to improve the maintainability of the configuration.

Comment on lines 4 to +7
- flagd-testbed
- open-feature-operator
- flagd-ofrep-cf-worker
- flagd-poc-benchmark
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's best to keep this list of repositories sorted alphabetically. This makes it easier to find items and prevent duplicates in the future. I've suggested sorting the items within this block to improve the ordering.

  - flagd-ofrep-cf-worker
  - flagd-poc-benchmark
  - flagd-testbed
  - open-feature-operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants