Packaging and Build Changes #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the project to use dependency
open-mpic-corefrom Test PyPI (will swap to non-test once I feel good about it, i.e. after others try it). So that has changed (simplified) the layer building quite a lot. Yes, some extra code gets pulled in that doesn't get used here and there, but I don't think it's a big deal. Not like we're using 100% of each other library we have in the dependency tree.I have also gotten rid of the
requirements.txtthat we've had to maintain for the lambda layer. Now I have a custom target in Hatch that we can use instead:hatch run lambda-layer:installand it does the thing. Which means we manage dependencies only inpyproject.toml. And now instead of./1-install.shand./2-package.shthere's just./package.sh. Other build and cleanup scripts are updated accordingly.One other thing I did, out of pure self-interest, is I parameterized the provisioning of DNSSEC-enabling resources in AWS. So if I want to just deploy ~1/3 of the resources, quickly, to do a quick and dirty integration test, I can do that, by writing
tofu apply -var="dnssec_enabled=false".