Added several integration tests #48
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration for contact email as well as bad port redirects that violate:
Redirects MUST be initiated at the HTTP protocol layer.
a. For validations performed on or after July 1, 2021, redirects MUST be the result
of a 301, 302, or 307 HTTP status code response, as defined in RFC 7231, Section
6.4, or a 308 HTTP status code response, as defined in RFC 7538, Section 3.
Redirects MUST be to the final value of the Location HTTP response header, as
defined in RFC 7231, Section 7.1.2.
b. For validations performed prior to July 1, 2021, redirects MUST be the result of
an HTTP status code result within the 3xx Redirection class of status codes, as
defined in RFC 7231, Section 6.4. CAs SHOULD limit the accepted status codes
and resource URLs to those defined within 1.a.
2. Redirects MUST be to resource URLs with either the “http” or “https” scheme.
3. Redirects MUST be to resource URLs accessed via Authorized Ports
Point 3 is currently tested. Point 2 I expect is implicitly handled since the URL is in an HTTP library. I may try some crazy 3xx codes later, but I would expect the library to be strict about what codes it accepts (hopefully).
Note, these integration tests for "Redirects MUST be to resource URLs accessed via Authorized Ports" currently fail because we do not enforce the port constraint on the http library.