Ds allow caa failure flag and set http timeout #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed timeout params to dcv checker (configuration not yet updated to set them). Removed vestigial reuse_http_client parameter in DCV checker. Added new integration test but it is not yet passing.
birgelee
reviewed
Sep 28, 2025
Member
birgelee
left a comment
birgelee
left a comment
There was a problem hiding this comment.
- why is the example config us-west-1 changed to us-east-2?
- README.md contains a permalink to the spec version (for better or for worse). This needs to be updated to the proper commit for 3.6.0
Collaborator
Author
The first one wasn't intended, will revert. (I think we had the Coordinator in us-east-2 the whole time and I thought why have it live alone.. but I forgot you updated the example to match MPIC Labs config.) Will update README as well. |
… revision of the spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the configuration and environment handling for the AWS Lambda functions, updates dependencies, and enhances integration test coverage and diagnostics. The main changes include adding support for new timeout configuration options, refactoring environment variable injection to reduce duplication, and updating dependencies for better compatibility and features. The integration tests have also been expanded and improved for better reliability and debugging.
Configuration and Environment Handling:
http-client-timeout-seconds,dns-timeout-seconds,dns-resolution-lifetime-seconds) inconfig.example.yaml, and ensured these are injected into the Lambda environment via Terraform templates (aws-perspective.tf.template). [1] [2] [3]configure.pyby introducing theset_common_env_configurationhelper, reducing code duplication and making it easier to add new environment variables. [1] [2] [3]Lambda Function Initialization:
MpicDcvCheckerLambdaHandlerandMpicCaaCheckerLambdaHandlerto read new timeout environment variables and pass them to their respective checker classes, improving configurability and robustness. [1] [2]Dependency and Version Updates:
pyproject.toml(aiohttp,open-mpic-core) and bumped the API spec version and package version for compatibility and feature improvements. [1] [2] [3]Integration Test Improvements:
test_deployed_mpic_api.pyto print responses when assertions fail, aiding debugging. Added a new test to check behavior when CAA lookup failures are allowed, and improved assertion placement for clarity. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Minor Documentation and Configuration Changes:
README.mdto clarify the order of deployment commands for DNSSEC and non-DNSSEC options.us-east-2.