Removing reuse of HTTP Client to address memory leak #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahanafy
approved these changes
Aug 15, 2025
Collaborator
ahanafy
left a comment
ahanafy
left a comment
There was a problem hiding this comment.
Looks good, i think this might solve some of the sporadic high latency issues I've seen in some scenarios with high concurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-mpic-coreincluded a split in logic for handling theClientSessionobject lifecycle, based on a flag (reuse_http_client-- now removed) that would be passed in as "true" for Docker-based wrappers and "false" for serverless (Lambda).Now the logic has been merged -- the HTTP client does not get reused between calls, so the logic is the same everywhere as it has been for Lambda.
The
force_close=Trueflag is also being set when creating the HTTP client.These changes are to address memory leaks we were experiencing at high, sustained volume.
This is a breaking change for the
open-mpic-containersandaws-lambda-pythonwrappers (NOT the MPIC client API defined inopen-mpic-specification), so this necessitates a major version bump.