added a flag allow_lookup_failure to CAA check parameters #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for handling DNS lookup failures during CAA checks, in accordance with updated Baseline Requirements, and improves error handling and test coverage for the CAA checking logic. It also bumps the API specification and package version. The main changes are grouped below.
CAA Lookup Failure Handling and Error Management:
allow_lookup_failureboolean parameter toCaaCheckParameters, enabling certain DNS lookup failures (e.g., timeouts, no nameservers) to be treated as valid for certificate issuance when explicitly allowed. [1] [2]check_caaandfind_caa_records_and_domainto distinguish between error types, log errors, and allow issuance for specific DNS failures if permitted by parameters. (F58c2971L57R57, [1] [2]Testing Enhancements:
allow_lookup_failure, including parametrized tests for different DNS error types and validation of error messages in responses. [1] [2]Version Updates:
spec_versioninpyproject.tomlfrom3.5.0to3.6.0to reflect API changes.__about__.pyfrom6.0.0to6.1.0.