Skip to content

Conversation

@msuliq
Copy link
Contributor

@msuliq msuliq commented Dec 11, 2025

Summary

  • Add format_host_for_url static method to wrap IPv6 addresses in square brackets for valid URL formatting
  • Update HTTP-based validation to use formatted host in URLs for both WEBSITE_CHANGE and ACME_HTTP_01 methods
  • Add unit tests covering IPv6/IPv4/domain handling in URL construction

Test plan

  • Verify format_host_for_url correctly wraps IPv6 addresses (including loopback, full form, zone ID)
  • Verify IPv4 addresses and domain names remain unchanged
  • Verify HTTP validation URLs contain properly bracketed IPv6 addresses
  • Run full test suite (130 tests passing)

Issues

Resolves #58

Add support for IPv6 formatting with square brackets
Add unit tests
Copy link
Member

@birgelee birgelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@sciros sciros merged commit 9f55827 into open-mpic:main Dec 19, 2025
1 check passed
@msuliq msuliq deleted the feat/ipv6-url-formatting branch December 20, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPv6 addresses fail DCV validation - bracketed addresses rejected, unbracketed addresses malform URLs

3 participants