Skip to content

Conversation

@davidhjp01
Copy link
Contributor

@davidhjp01 davidhjp01 commented Apr 30, 2025

Ecco API is added see the changes in cosim.h for added / modified functions.

@davidhjp01 davidhjp01 requested a review from restenb April 30, 2025 17:09
@davidhjp01 davidhjp01 requested a review from kyllingstad May 2, 2025 07:41
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have almost nothing to add, you did a great job here.

src/cosim.cpp Outdated
#include <cosim/osp_config_parser.hpp>
#include <cosim/ssp/ssp_loader.hpp>
#include <cosim/time.hpp>
#include <cosim/algorithm/ecco_algorithm.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Includes should be in alphabetical order.

@davidhjp01 davidhjp01 merged commit 9502944 into master May 5, 2025
16 checks passed
@davidhjp01 davidhjp01 deleted the ecco-update branch May 5, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants