Replace Xlint deprecation check with custom errorprone check#16122
Merged
trask merged 7 commits intoopen-telemetry:mainfrom Feb 10, 2026
Merged
Replace Xlint deprecation check with custom errorprone check#16122trask merged 7 commits intoopen-telemetry:mainfrom
trask merged 7 commits intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
improve-deprecating-experience
branch
from
0f37e36 to
d63aa88
Compare
trask
commented
Feb 10, 2026
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | ||
| * any time. | ||
| */ | ||
| @SuppressWarnings("OtelDeprecatedApiUsage") // SPDY_3 is deprecated but still used in okhttp 3.x |
Member
Author
There was a problem hiding this comment.
it's slightly stricter than javac here, but this does align with Intellij's warnings, so seems good
trask
force-pushed
the
improve-deprecating-experience
branch
from
c105f8d to
b458328
Compare
trask
force-pushed
the
improve-deprecating-experience
branch
4 times, most recently
from
64e62a0 to
10e50f5
Compare
trask
force-pushed
the
improve-deprecating-experience
branch
from
10e50f5 to
3f8d39b
Compare
laurit
reviewed
Feb 10, 2026
| io.opentelemetry.instrumentation.api.internal.HttpRouteState agentRouteState = | ||
| io.opentelemetry.instrumentation.api.internal.HttpRouteState.fromContextOrNull( | ||
| agentContext); | ||
| HttpRouteState agentRouteState = HttpRouteState.fromContextOrNull(agentContext); |
Contributor
There was a problem hiding this comment.
I think that in bridging instrumentation the convention is that agent versions of the classes use fqn and application classes are imported. I guess it is fine to import the agent class when application class is not used.
Member
Author
There was a problem hiding this comment.
oh yeah, I thought I reverted all of these, but missed this
I'm considering following up and flipping the convention to use fqcn for the application.* classes which would allow us to set up a custom errorprone check to enforce it
laurit
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to open-telemetry/opentelemetry-java#8061