opentelemetry-instrumentation-urllib: switch from httpretty to pook#4282
Draft
xrmx wants to merge 3 commits intoopen-telemetry:mainfrom
Draft
opentelemetry-instrumentation-urllib: switch from httpretty to pook#4282xrmx wants to merge 3 commits intoopen-telemetry:mainfrom
xrmx wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
xrmx
force-pushed
the
move-urllib-to-pook
branch
from
eab9a59 to
e1fd263
Compare
Contributor
Author
|
This requires a couple of PRs to pook to get merged and released: |
|
@xrmx I've cut a release of pook with your two changes: https://github.com/h2non/pook/releases/tag/v2.1.6 Thanks again for the contributions! |
emdneto
reviewed
Mar 6, 2026
instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
Outdated
Show resolved
Hide resolved
xrmx
force-pushed
the
move-urllib-to-pook
branch
from
cc0c7b6 to
f72da60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move urllib tests away from httpretty since it's not maintained anymore since years.
Assisted-by: Cursor
Refs #4200
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.