-
Notifications
You must be signed in to change notification settings - Fork 60
Update-Markdown now supports v2 #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
+ Coverage 79.4% 79.6% +0.1%
=======================================
Files 98 99 +1
Lines 7329 7617 +288
=======================================
+ Hits 5822 6064 +242
- Misses 1507 1553 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Going to hold off on this PR for a few revamps. Ideas:
|
|
@lmolkova PTAL at this again - I was able to implement the JQ idea I mentioned. |
This takes an approach where we have guaranteed strings to access portions of the resolved schema:
registry.vs.refinements.access those portions, then, you can dive deeper via the signal type, e.g.registry.spans.{id},refinements.events.{id}For no good reason, I added
registry.attributes.{id}if you want to pull an attribute snippet.