Skip to content

Conversation

@jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Dec 8, 2025

This takes an approach where we have guaranteed strings to access portions of the resolved schema:

registry. vs. refinements. access those portions, then, you can dive deeper via the signal type, e.g. registry.spans.{id}, refinements.events.{id}

For no good reason, I added registry.attributes.{id} if you want to pull an attribute snippet.

@jsuereth jsuereth requested a review from a team as a code owner December 8, 2025 21:22
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 80.62500% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.6%. Comparing base (648b3a6) to head (773254f).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_semconv_gen/src/v2.rs 73.0% 48 Missing ⚠️
crates/weaver_semconv_gen/src/parser.rs 91.1% 8 Missing ⚠️
crates/weaver_semconv_gen/src/lib.rs 86.2% 4 Missing ⚠️
crates/weaver_semconv_gen/src/v1.rs 88.2% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1064     +/-   ##
=======================================
+ Coverage   79.4%   79.6%   +0.1%     
=======================================
  Files         98      99      +1     
  Lines       7329    7617    +288     
=======================================
+ Hits        5822    6064    +242     
- Misses      1507    1553     +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsuereth jsuereth moved this to To consider for the next release in OTel Weaver Project Dec 10, 2025
@jsuereth
Copy link
Contributor Author

Going to hold off on this PR for a few revamps.

Ideas:

  • Move from <!-- semconv {group}({attributes}) --> to <!-- weaver {jq_expr} {template_file} --> for more flexibility
  • Default to refinements to simplify 90% of usage.
  • JQ helper functions to create namespaces for attributes.
  • Snippets to support namespaces.

@jsuereth jsuereth moved this from To consider for the next release to V2 Schema in OTel Weaver Project Dec 10, 2025
@jsuereth
Copy link
Contributor Author

@lmolkova PTAL at this again - I was able to implement the JQ idea I mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: V2 Schema

Development

Successfully merging this pull request may close these issues.

2 participants