fix: make trace_include_sensitive_data secure by default#2441
Draft
OiPunk wants to merge 3 commits intoopenai:mainfrom
Draft
fix: make trace_include_sensitive_data secure by default#2441OiPunk wants to merge 3 commits intoopenai:mainfrom
OiPunk wants to merge 3 commits intoopenai:mainfrom
Conversation
Member
|
Thanks for sending this patch! However, since this is a breaking change, we don't plant to make the change in the short term. |
Contributor
Author
|
Follow-up pushed to fix current CI failures on this PR. Root cause:
Fix:
Commit: Local verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes tracing safer by default by switching the default of
RunConfig.trace_include_sensitive_datafromTruetoFalsewhenOPENAI_AGENTS_TRACE_INCLUDE_SENSITIVE_DATAis not set.This aligns runtime behavior with secure-by-default expectations and documentation.
Fixes #2393
Changes
_default_trace_include_sensitive_data()env fallback from"true"to"false"insrc/agents/run_config.pytests/test_run_config.pydocs/tracing.mdto state the default isFalseTesting
uv run ruff format --checkuv run ruff checkuv run mypy . --exclude siteuv run pytest tests/test_run_config.py tests/test_agent_runner.py -k trace_include_sensitive_data -quv run coverage run -m pytest tests/test_run_config.py tests/test_agent_runner.py -k trace_include_sensitive_data -quv run coverage report -m src/agents/run_config.pyCoverage
src/agents/run_config.py: 100% (106/106)