Merged
Conversation
8bb84a2 to
afc83b2
Compare
afc83b2 to
2b4469d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.8.3 -> TARGET 2b4469d)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.8.3...2b4469d
Release call:
🟢 GREEN LIGHT TO SHIP No concrete release-blocking regressions found; follow-up validation suggested for new shell/MCP behaviors.
Scope summary:
src/agents/(tools, turn resolution, MCP, responses),tests/,examples/tools/, docs (including translations), dependency bump.Risk assessment (ordered by impact):
MCP tool calls now pre-validate required parameters
UserError._validate_required_parametersinvoked beforecall_toolinsrc/agents/mcp/server.py.src/agents/mcp/server.pyuv run pytest -s tests/mcp/test_client_session_retries.pyand confirm missing-parameter calls raise the expectedUserError.Shell tool hosted environment handling and shell_call_output normalization
src/agents/tool.py; hosted shell calls skipped insrc/agents/run_internal/turn_resolution.py; shell tool payload includesenvironmentinsrc/agents/models/openai_responses.py.src/agents/tool.py,src/agents/run_internal/turn_resolution.py,src/agents/models/openai_responses.py,src/agents/run_internal/tool_actions.pyuv run pytest -s tests/test_shell_tool.py tests/test_local_shell_tool.pyand confirm local shell still executes while hosted environments do not.Prompt-managed tool_choice omission adjusted
tool_choicenow omitted only for dict choices insrc/agents/models/openai_responses.py.src/agents/models/openai_responses.pyuv run pytest -s tests/test_openai_responses.py -k tool_choiceand verify expected tool_choice serialization.Notes:
v0.8.3. TARGET:2b4469dcf50d700add43b84477f0d250b71c1446.